Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Internal: Updated the usage of UI components which are now driven by …
Browse files Browse the repository at this point in the history
…synchronous initialization and destruction (see https://github.com/ckeditor/ckeditor5-ui/issues/225).
  • Loading branch information
Reinmar committed Jul 5, 2017
2 parents 074356a + 96bcfc9 commit 859c29b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/ui/filedialogbuttonview.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default class FileDialogButtonView extends ButtonView {
destroy() {
document.body.removeChild( this.fileInputView.element );

return super.destroy();
super.destroy();
}
}

Expand Down
6 changes: 3 additions & 3 deletions tests/ui/filedialogbuttonview.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ describe( 'FileDialogButtonView', () => {
} );

it( 'should remove input view from body after destroy', () => {
return view.destroy().then( () => {
expect( view.fileInputView.element.parentNode ).to.be.null;
} );
view.destroy();

expect( view.fileInputView.element.parentNode ).to.be.null;
} );

it( 'should open file dialog on execute', () => {
Expand Down

0 comments on commit 859c29b

Please sign in to comment.