Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Fix: Improved destroying of FileDialogButtonView. #67

Merged
merged 4 commits into from
Oct 10, 2017
Merged

Fix: Improved destroying of FileDialogButtonView. #67

merged 4 commits into from
Oct 10, 2017

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Oct 9, 2017 •
edited by pomek
Loading

Suggested merge commit message (convention)

Fix: Improved destroying of FileDialogButtonView. Closes ckeditor/ckeditor5#2825.

BREAKING CHANGE: The FileDialogButtonView is not a ButtonView instance anymore. ButtonView is implemented as a FileDialogButtonView child and is available under the FileDialogButtonView#buttonView property.

@oskarwrobel oskarwrobel requested review from oleq and szymonkups October 9, 2017 13:04
@oskarwrobel
Copy link
Contributor Author

I didn't bind buttonView API to FileDialogButtonView but I'm wondering if ToolbarView items should have consistent API? Should we define some interface for toolbar items?

@oleq
Copy link
Member

oleq commented Oct 10, 2017

Yes, we should define such an interface. Because at this moment the button is not focusable (needs focus() method):
kapture 2017-10-10 at 10 25 56

@oskarwrobel
Copy link
Contributor Author

Focus interface is added.

@oleq oleq merged commit 2d4ba62 into master Oct 10, 2017
@oleq oleq deleted the t/66 branch October 10, 2017 14:18
@oleq oleq mentioned this pull request Oct 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oleq oleq Awaiting requested review from oleq

@szymonkups szymonkups Awaiting requested review from szymonkups

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor with upload plugin throws an error when destroy is called more than once
2 participants
@oskarwrobel @oleq