Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change way of setting data #51

Closed
ma2ciek opened this issue Apr 24, 2019 · 0 comments · Fixed by #52
Closed

Change way of setting data #51

ma2ciek opened this issue Apr 24, 2019 · 0 comments · Fixed by #52
Assignees
@oleq
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 25

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 24, 2019

A follow-up to #47.

We shouldn't use the el.innerHTML unless it's necessary, because it can easily provide some attack vectors and is slow for large contents. We should use the initialValue property instead.
@ma2ciek ma2ciek added type:task This issue reports a chore (non-production change) and other types of "todos". status:confirmed labels Apr 24, 2019
@ma2ciek ma2ciek added this to the iteration 24 milestone Apr 24, 2019
@oleq oleq self-assigned this Apr 24, 2019
@oleq oleq mentioned this issue Apr 24, 2019
Merged
@mlewand mlewand modified the milestones: iteration 24, next May 13, 2019
ma2ciek added a commit that referenced this issue Jun 14, 2019
@ma2ciek
T/51: Used config.initialData instead of innerHTML to set the ini…
950b49a 
…tial state of the editor (#52)

Internal: Used `config.initialData` instead of `innerHTML` to set the initial state of the editor. Closes #51.
@Reinmar Reinmar modified the milestones: next, iteration 25 Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 25
4 participants
@Reinmar @oleq @ma2ciek @mlewand