Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t/1b: Simplified the component by removing componentName and editors from the plugin options #9

Merged
merged 5 commits into from
Nov 6, 2018
Merged

t/1b: Simplified the component by removing componentName and editors from the plugin options #9

merged 5 commits into from
Nov 6, 2018

Conversation

oleq
Copy link
Member

@oleq oleq commented Nov 5, 2018 •
edited
Loading

Suggested merge commit message (convention)

Other: Simplified the component by removing componentName and editors from the plugin options (see #1). Closes #7.

Additional information

Changes in the documentation.

@oleq oleq requested review from Reinmar and pomek November 5, 2018 17:03
@oleq oleq mentioned this pull request Nov 5, 2018
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 30

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 26: 0.0%
Covered Lines: 27
Relevant Lines: 27
💛 - Coveralls

pomek
pomek approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works.

@Reinmar Reinmar merged commit 81c2fe9 into master Nov 6, 2018
@Reinmar Reinmar deleted the t/1b branch November 6, 2018 10:45
@ThibaultVlacich ThibaultVlacich mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

@Reinmar Reinmar Awaiting requested review from Reinmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleq @coveralls @pomek @Reinmar