Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/66: Renamed .ck-widget_selectable to .ck-widget_with-selection-handler. #67

Merged
merged 1 commit into from
Jan 17, 2019
Merged

t/66: Renamed .ck-widget_selectable to .ck-widget_with-selection-handler. #67

merged 1 commit into from
Jan 17, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Jan 17, 2019 •
edited by pomek
Loading

Suggested merge commit message (convention)

Other: Renamed the .ck-widget_selectable class to .ck-widget_with-selection-handler for better semantics. Closes ckeditor/ckeditor5#4598.

BREAKING CHANGE: The .ck-widget_selectable class has been renamed to .ck-widget_with-selection-handler for better semantics.

Additional information

Requires:

@oleq oleq requested a review from dkonopka January 17, 2019 12:46
This was referenced Jan 17, 2019
Merged
Merged
@oleq oleq requested a review from jodator January 17, 2019 12:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 359af47 on t/66 into 7e11a24 on master.

dkonopka
dkonopka approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@dkonopka dkonopka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM 👍

@dkonopka dkonopka merged commit 178ad5f into master Jan 17, 2019
@dkonopka dkonopka deleted the t/66 branch January 17, 2019 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkonopka dkonopka dkonopka approved these changes

@jodator jodator Awaiting requested review from jodator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@oleq @coveralls @dkonopka