This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add aria-label for widget's toolbar #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
suggested changes
Jul 19, 2019
src/widgettoolbarrepository.js
Outdated
| const toolbarView = new ToolbarView(); | ||
| const locale = this.editor.locale; | ||
| const t = locale.t; | ||
| const toolbarView = new ToolbarView( locale, { ariaLabel: t( 'Widget\'s toolbar' ) } ); |
There was a problem hiding this comment.
-
As I pointed out in Add label for editor's toolbar ckeditor5-ui#500, the
ariaLabelshould be a property. -
#registershould allow customization ofariaLabel(defaultt( 'Widget toolbar' )). -
Having the above, we need PRs in
- ckeditor5-image
- ckeditor5-table
- ckeditor5-media-embed
that will correctly describe widgets introduced by the features ("Image toolbar", "Table toolbar", etc.)
There was a problem hiding this comment.
I've updated the description for PR to link changes in image, table, media-embed.
Co-Authored-By: Aleksander Nowodzinski <a.nowodzinski@cksource.com>
This was referenced Aug 9, 2019
oleq
reviewed
Aug 13, 2019
oleq
reviewed
Aug 13, 2019
…UI language directions.
…UI language directions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Adds aria-label for widget's toolbar.
Additional information
Requires: ckeditor/ckeditor5-ui#500
Required by:
aria-labelfor table toolbar ckeditor5-table#201aria-labelfor image toolbar ckeditor5-image#302aria-labelfor media embed toolbar ckeditor5-media-embed#88