-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's hard to escape from link areas #1016
Comments
If I understood you correctly, this is an expected behavior - a feature, rather than a bug. This way we are giving the user a possibility - to write inside or outside the link - when the caret is at the end of it. Highlight behind the link denotes whether the caret is inside the link or not. We could discuss if this should be a configurable option but the gain provided by this feature is much bigger than the loss. |
My concern on this is that the majority of Users will not understand why they have to double tap the right button to continue writing as normal. Well its only a Problem if you mark the last text symbols and make it a link and then try to write further without expanding the link. double Tap right is not really intuitive. i pressed space escape, but nothing helped. If it would be the bold or italic button you just hit it again. with links its more complicated. So, yes its a very unexpected behavior. Not a Bug. greetings, Ralf |
I agree that at the end of the block it might be less intuitive to discover this feature. Thanks for your input. We'll discuss what to do next. |
The problem is that both options are bad:
In CKEditor 4 we have the 1st situation and it's irritating. It forces you to do some odd things to change the text of a link. In CKEditor 5 we had the 2nd situation and it also forced you to do odd things (this time – to type without a link). When looking for the default behaviour we may need to understand which of these is a lesser evil. Because, if we assume that the user is not aware of the two-step caret movement, we also assume that the problems described above will occur. Either one of them or the other. I agree that we could e.g. change the behaviour (the gravity of the selection) on user click, so when the user clicked at the end of a link, the selection would not inherit the link. But to make a decision, we need to get more feedback to not change something bad into something even worse. |
After some thinking about it, i would suggest a combination of both behaviors, the caret could be placed just right outside of the link, so you can type further without the need of do anything else, but if i want to expand the link i have to place the caret with mouse or keyboard inside the link, if i do i do it intentional. In my Opinion that would be a great option. |
I'd be very interested in the solution suggested by @ralfbeine or in a configurable option to place the caret after the link. @Reinmar: Is there any workaround I can use for now until this is implemented? I tried manually triggering an arrow-right keyboard event on the source element but that doesn't work. |
I had the same idea as @ralfbeine - put caret outside of the link by default but also leave the current implementation where you can enter the link using mouse or arrow keys. This will allow users to type standard text or enter the link if they want to further edit it. |
The expected behavior, for me, would be that:
I believe this is how things work in Google Docs as well as many other editors I've used. |
Okay, I just faced the same issue as others. My use case: I'm writing a text and then hit the "Link" button, type I'm inside the link so I press Conclusion: maaaaybe we should consider something like user intention or sth. I just inserted a link, the link is at the end of the paragraph, in 99.9999% of cases I simply want to type plain text after it. Pressing arrow right twice is counter intuitive in this case. |
There are two things here:
|
+1 |
Other (link): The selection after inserting a link will land after the inserted element. Thanks to that a user will be able to type directly after the link without extending the link element. Closes #1016. Other (link): After clicking at the beginning or end of the link element, the selection will land before/after the clicked element. Thanks to that a user will be able to typing before or after the link element as normal text without extending the link. See #1016.
🆕 Feature request
💻 Version of CKEditor
ckeditor5/10.0.0
classic build
📋 Steps to reproduce
✅ Expected result
if i continue to type i would not expect to enlarge the link area i just defined. It would be totally o.k. to redo the link actions if i need to change this.
❎ Actual result
I'm prisoner of a link and had much difficulties to find out how to escape.
📃 Other details that might be useful
none... just change it please. And thank you for your great work!
The text was updated successfully, but these errors were encountered: