Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to start list index from 0 #12827

Closed
FilipTokarski opened this issue Nov 10, 2022 · 4 comments · Fixed by #12884
Closed

Allow to start list index from 0 #12827

FilipTokarski opened this issue Nov 10, 2022 · 4 comments · Fixed by #12884
Assignees
Labels
intro Good first ticket. package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@FilipTokarski
Copy link
Member

📝 Provide a description of the improvement

Currently when setting list start index, you cannot go below value 1. However, some use cases require starting list numbering from value 0.

It would be good to enhance this feature and allow starting lists from 0.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:improvement This issue reports a possible enhancement of an existing feature. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:list squad:core Issue to be handled by the Core team. labels Nov 10, 2022
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Nov 10, 2022
@mlewand mlewand added the intro Good first ticket. label Nov 10, 2022
@mlewand
Copy link
Contributor

mlewand commented Nov 10, 2022

@FilipTokarski can you provide what are those use cases that require 0 start?

@Reinmar
Copy link
Member

Reinmar commented Nov 16, 2022

I checked Google Docs too. Negative numbers are not allowed, but 0 is. 

I don't think it requires more analysis. It's a simple and safe change.

@Reinmar
Copy link
Member

Reinmar commented Nov 16, 2022

Scope:

  • We've got one UI for both types of lists (List and DocumentList). So this change need to be made in two of them.
  • One potential issue is that 0 might be treated as a falsy value at some point during a conversion.

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Nov 16, 2022
@108signals
Copy link

@mlewand @FilipTokarski we had the same question for our customer. Here's the use case: an organization has a budget request starting with #1 that goes through a long budget process where each list item is significant and now referred to by their number. Near the end an additional item that conceptually belongs before #1 is identified and also approved by budget. Yes an edge case but good to hear this is a simple and safe change.

@mremiszewski mremiszewski self-assigned this Nov 17, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Nov 17, 2022
niegowski added a commit that referenced this issue Nov 25, 2022
…index-from-0

Feature (lists): Allow list indexing to start from 0. Closes #12827.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 25, 2022
@CKEditorBot CKEditorBot added this to the iteration 59 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants