-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define JSHint globals #13
Comments
I've been using the The nice thing is that JSHint points out unused entries in this comment so we always have it clean. Therefore, when it comes to tests, I'm ok to keep using the comments... but I'm also ok to have them in the grunt config file... I mean, I'm ok with what the team will find is better. Just wanted to report my recent experience with it here. |
I'm ok with both solutions - defining all globals in every file or defining wide set of globals in the global config (https://github.com/ckeditor/ckeditor5/pull/11/files#r23292195). Since you started the first way, we can continue it. |
Agreed. |
Internal: Fixed stylelint errors related to colors and indentation (see ckeditor/ckeditor5-dev#611).
…rForm RotaryChair/VHIT/VAT
Based on https://github.com/ckeditor/ckeditor5/pull/11/files#r23282090.
I wasn't sure if I shouldn't report this ticket in ckeditor/ckeditor5-design repository, but we'll need this one anyway, so let's start here :).
The text was updated successfully, but these errors were encountered: