Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define JSHint globals #13

Closed
Reinmar opened this issue Feb 13, 2015 · 3 comments
Closed

Define JSHint globals #13

Reinmar opened this issue Feb 13, 2015 · 3 comments
Labels
type:question This issue asks a question (how to...).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 13, 2015

Based on https://github.com/ckeditor/ckeditor5/pull/11/files#r23282090.

I wasn't sure if I shouldn't report this ticket in ckeditor/ckeditor5-design repository, but we'll need this one anyway, so let's start here :).

@Reinmar Reinmar added the type:question This issue asks a question (how to...). label Feb 13, 2015
@fredck
Copy link
Contributor

fredck commented Feb 16, 2015

I've been using the /* global */ comment on tests with some good success. Usually we start a test from a copy-paste from an existing one (for header, etc..), so that comment comes together.

The nice thing is that JSHint points out unused entries in this comment so we always have it clean.

Therefore, when it comes to tests, I'm ok to keep using the comments... but I'm also ok to have them in the grunt config file... I mean, I'm ok with what the team will find is better. Just wanted to report my recent experience with it here.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 16, 2015

I'm ok with both solutions - defining all globals in every file or defining wide set of globals in the global config (https://github.com/ckeditor/ckeditor5/pull/11/files#r23292195). Since you started the first way, we can continue it.

@fredck
Copy link
Contributor

fredck commented Jun 12, 2015

Agreed.

@fredck fredck closed this as completed Jun 12, 2015
@Reinmar Reinmar modified the milestone: 0.1.0 Mar 4, 2016
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Fixed stylelint errors related to colors and indentation (see ckeditor/ckeditor5-dev#611).
Talhafayyaz11 pushed a commit to Talhafayyaz11/ckeditor5 that referenced this issue Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

2 participants