Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crashes after inserting a new line after an image in a blockquote #1555

Closed
Mgsy opened this issue Feb 20, 2019 · 0 comments Β· Fixed by ckeditor/ckeditor5-widget#75
Closed
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Mgsy
Copy link
Member

Mgsy commented Feb 20, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

πŸ’» Version of CKEditor

Latest master.

πŸ“‹ Steps to reproduce

  1. Upload an image.
  2. Wrap it in a blockquote.
  3. Focus the image and press Enter.

βœ… Expected result

A new line is inserted.

❎ Actual result

The editor crashes.

πŸ“ƒ Other details that might be useful

GIF
bug_cke5

Error

ckeditorerror.js:46 Uncaught CKEditorError: model-position-path-incorrect: Position path must be an array with at least one item. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-model-position-path-incorrect
 {"path":[]}
    at new Kr (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:134649)
    at Function.getInsertionPosition (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:218698)
    at new fl (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:216685)
    at gl.split (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:224126)
    at Object.e.change.i [as callback] (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:357738)
    at Kl._runPendingChanges (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:257828)
    at Kl.change (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:255271)
    at vd._handleEnterKey (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:357567)
    at vd._onKeydown (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:356539)
    at os.listenTo.t (http://192.168.1.48:8081/build/docs/ckeditor5/latest/snippets/build-classic-source/snippet.js:4:355763)

It's a regression.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Feb 20, 2019
@Reinmar Reinmar added this to the iteration 22 milestone Feb 20, 2019
@jodator jodator self-assigned this Feb 20, 2019
oskarwrobel added a commit to ckeditor/ckeditor5-widget that referenced this issue Feb 21, 2019
Fix: Editor crashes after Enter key on an image that is inside a blockquote. Closes ckeditor/ckeditor5#1555.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants