Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly visual differences between using ckeditor5.css and ckeditor5-editor.css with ckeditor5-content.css. #16703

Closed
pszczesniak opened this issue Jul 10, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#979
Closed

Slightly visual differences between using ckeditor5.css and ckeditor5-editor.css with ckeditor5-content.css. #16703

pszczesniak opened this issue Jul 10, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#979
Assignees
@pszczesniak
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 76 (v43...

Comments

@pszczesniak
Copy link
Contributor

pszczesniak commented Jul 10, 2024 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Open editor included ckeditor5.css
  2. Open editor included ckeditor5-editor.css with ckeditor5-content.css
  3. Compare both.

✔️ Expected result

Should look exactly the same.

❌ Actual result

There are slightly visual differences.

❓ Possible solution

Investigation needed.

First thought: some CSS variables can be overwritten somehow; Second thought: CSS order - same specificity selectors can be overwritten.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@pszczesniak pszczesniak added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. labels Jul 10, 2024
@pszczesniak pszczesniak self-assigned this Jul 10, 2024
@pszczesniak pszczesniak mentioned this issue Jul 10, 2024
Closed
@filipsobol filipsobol mentioned this issue Jul 11, 2024
Closed
@pszczesniak pszczesniak mentioned this issue Jul 18, 2024
Merged
pszczesniak added a commit to ckeditor/ckeditor5-dev that referenced this issue Jul 19, 2024
@pszczesniak
Merge pull request #979 from ckeditor/new-apporach-for-splitting-css-…
2b0feb3 
…into-editor-and-content-stylsheets

Fix (build-tools): Should preserved all needed selectors and at-rules in CSS files after split into editor and content stylesheets. Closes ckeditor/ckeditor5#16703.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 19, 2024
@KISSAdmin KISSAdmin mentioned this issue Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pszczesniak pszczesniak

Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 76 (v43.0.0)
2 participants
@pszczesniak @CKEditorBot