Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloon Editor toolbar sticks out of the limiter element while scrolling #17002

Closed
michalbilik opened this issue Aug 29, 2024 · 5 comments
Closed
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui release:potential-blocker This issue potentially blocks the upcoming release (should be checked). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@michalbilik
Copy link
Contributor

michalbilik commented Aug 29, 2024

📝 Provide detailed reproduction steps (if any)

Also reproducible on the release branch, and in the ckeditor5-ui/tests/manual/blocktoolbar/scrollable-blocktoolbar.html manual test.

  1. Open https://ckeditor.com/docs/ckeditor5/latest/examples/builds/balloon-block-editor.html
  2. Add style="max-height: 300px; max-width: 400px; overflow: auto;" style to the parent container of ck-editor__editable.
<div class="live-snippet" style="max-height: 300px; max-width: 400px; overflow: auto;">
</div>
  1. Select some content, and press the Balloon Block button (⠿).
  2. Scroll up or down.

✔️ Expected result

The toolbar hides when scrolling.

❌ Actual result

The toolbar moves with the scroll and does not hide.

Screen.Recording.2024-08-29.at.12.01.51.mov

❓ Possible solution

Related to: #5460

📃 Other details

  • Browser: all
  • OS: macOS
  • First affected CKEditor version: 43.0.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@michalbilik michalbilik added type:bug This issue reports a buggy (incorrect) behavior. package:ui domain:ui/ux This issue reports a problem related to UI or UX. type:regression This issue reports a bug that was not present in the previous releases. squad:core Issue to be handled by the Core team. release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Aug 29, 2024
@Mati365 Mati365 self-assigned this Aug 29, 2024
@Mati365
Copy link
Member

Mati365 commented Aug 29, 2024

Follow-up of #16685

@niegowski
Copy link
Contributor

The case of a contextual balloon is not a regression. Only the block balloon toolbar is a regression.

@Mati365
Copy link
Member

Mati365 commented Aug 29, 2024

@michalbilik can you split this ticket into two separate issues? First one about Case 1, and the second one about Case 2?

@Mati365 Mati365 removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Aug 29, 2024
@michalbilik michalbilik changed the title Balloon Editor toolbar and ballon panel sticks out of the limiter element while scrolling Balloon Editor toolbar sticks out of the limiter element while scrolling Aug 29, 2024
@michalbilik
Copy link
Contributor Author

The contextual balloon issue was moved to: #17009.

@Mati365
Copy link
Member

Mati365 commented Aug 29, 2024

Thanks!

@Witoso Witoso added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Aug 30, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 30, 2024
Mati365 added a commit that referenced this issue Sep 2, 2024
Fix (ui): Balloon Editor toolbar no longer sticks out of the limiter element while scrolling. Closes #17002
@Mati365 Mati365 closed this as completed Sep 2, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 2, 2024
@Witoso Witoso added this to the iteration 77 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui release:potential-blocker This issue potentially blocks the upcoming release (should be checked). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

No branches or pull requests

5 participants