Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade postcss-nesting in ckeditor5-dev-*@^43 #17449

Closed
pomek opened this issue Nov 13, 2024 · 1 comment
Closed

Upgrade postcss-nesting in ckeditor5-dev-*@^43 #17449

pomek opened this issue Nov 13, 2024 · 1 comment
Assignees
@pomek
Labels
package:dev resolution:resolved This issue was already resolved (e.g. by another ticket). squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Nov 13, 2024 •
edited
Loading

Provide a description of the task

The latest ckeditor5-dev-* packages are ESM only. If an integrator cannot upgrade, it can result in invalid CSS definitions after these changes #17132 (due to @nest). Hence, we need to upgrade the postcss-nesting package (and its configuration) on the @latest version of the ckeditor5-dev-* packages.

Definition of Done

  • Ability to release the 43.X.Y branch from a non-master branch.
  • Cherry-pick changes related to postcss-nesting from the 45.X.Y branch.
    • The postcss-nesting should be used in the latest version (13?).
    • The postcss configuration needs the edition field. (ref)
@pomek pomek added package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Nov 13, 2024
@pomek pomek self-assigned this Nov 13, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 13, 2024
@pszczesniak pszczesniak mentioned this issue Nov 13, 2024
Open
@pomek pomek mentioned this issue Nov 13, 2024
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Nov 13, 2024
@pomek
Merge pull request #1046 from ckeditor/ck/17449
43db12f 
Fix (utils): Upgrade the `postcss-nesting` package to the latest version to avoid issues with non-supported `@nest` selectors. Closes ckeditor/ckeditor5#17449.

Internal (build-tools): Upgrade `postcss-nesting` to the latest version.
@pomek pomek changed the title Upgrade postcss-nexting in ckeditor5-dev-*@^43 Upgrade postcss-nesting in ckeditor5-dev-*@^43 Nov 13, 2024
@pomek
Copy link
Member Author

pomek commented Nov 13, 2024

Done in ckeditor/ckeditor5-dev#1046.

@pomek pomek closed this as completed Nov 13, 2024
@pomek pomek added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Nov 13, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:dev resolution:resolved This issue was already resolved (e.g. by another ticket). squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pomek @CKEditorBot