Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image widgets should not be forced to consume the entire width #1870

Closed
mlewand opened this issue Jul 9, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#297
Closed

Image widgets should not be forced to consume the entire width #1870

mlewand opened this issue Jul 9, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#297
Assignees
@dkonopka
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 26

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 9, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.1.0

📋 Steps to reproduce

Image widgets (the wrapper) currently consume entire contianer's width, even if an image is much narrower than the container.

✅ Expected result

Wrapper should be reduced to minimal required width.

❎ Actual result

image

Wrapper spans over entire container's width.
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. status:confirmed labels Jul 9, 2019
@mlewand mlewand added this to the next milestone Jul 9, 2019
@dkonopka dkonopka mentioned this issue Jul 12, 2019
Merged
oleq added a commit to ckeditor/ckeditor5-image that referenced this issue Jul 19, 2019
@oleq
Merge pull request #297 from ckeditor/t/ckeditor5/1870
b82ea85 
Fix: Image widgets should not span the entire width of the editor. Closes ckeditor/ckeditor5#1870.

BREAKING CHANGE: From now on, all images in the editor use CSS `display: table` by default (`.ck-content .image { display: table }`). It can affect integrations and we recommend checking if images render correctly in your project after this update. There is a possibility you might need to adjust the CSS to adapt to this change.
@oleq oleq modified the milestones: next, iteration 26 Jul 19, 2019
@Reinmar Reinmar changed the title Image widgets should not be forced to consume an entire width Image widgets should not be forced to consume the entire width Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Image widgets should not be forced to consume an entire width ckeditor/ckeditor5-image
3 participants
@oleq @mlewand @dkonopka