Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Enter causes weird issues with code element #1955

Closed
jswiderski opened this issue Aug 12, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-autoformat#76
Closed

Shift+Enter causes weird issues with code element #1955

jswiderski opened this issue Aug 12, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-autoformat#76
Assignees
Labels
support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jswiderski
Copy link

jswiderski commented Aug 12, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report | 🆕 Feature request | Other

💻 Version of CKEditor

12.3.1

📋 Steps to reproduce

  1. Open https://ckeditor.com/docs/ckeditor5/latest/features/basic-styles.html
  2. Type Test and press Shift +Enter
  3. Type `test`
  4. Press space
  5. Type `test`
  6. Delete "t`" using back space and start typing works test all the time

Please also have a look at attached screen-case to get a better idea how to reproduce this issue
bug.zip

✅ Expected result

Both `test` should get converted to code elements

❎ Actual result

  1. The first `test` remains unchanged
  2. the second gets "code style" applied plus some weird text rewinding. Please see attached screen-cast.

📃 Other details that might be useful

Original support issue - 56930

@jswiderski jswiderski added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 12, 2019
@jswiderski
Copy link
Author

Another use case:

1 Type whatever,
2. Press Shift+Enter,
3. Type `a`a`a`a`a`a`a`a`a`a`
It breaks after ~5 repetitions of the a+backtick.
Screen-cast bug2.zip

@Reinmar Reinmar added this to the iteration 27 milestone Aug 12, 2019
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Aug 21, 2019
@mlewand mlewand assigned mlewand and jodator and unassigned mlewand Sep 2, 2019
@jodator
Copy link
Contributor

jodator commented Sep 11, 2019

Breaks also the text transformation in a similar fashion - wrong position are used to replace quotes:
Selection_028

The second test should be replaced.

scofalik added a commit to ckeditor/ckeditor5-typing that referenced this issue Sep 12, 2019
Fix: Autoformat transformations in blocks containing inline elements. See ckeditor/ckeditor5#1955.
scofalik added a commit to ckeditor/ckeditor5-autoformat that referenced this issue Sep 12, 2019
Fix: Autoformat transformations in blocks containing inline elements. Closes ckeditor/ckeditor5#1955.
bendemboski pushed a commit to PatentNavigation/ckeditor5-typing-v19 that referenced this issue Aug 18, 2020
Fix: Autoformat transformations in blocks containing inline elements. See ckeditor/ckeditor5#1955.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants