The InsertTableCommand should break paragraph where the selection is anchored

[jodator]

As @oleq pointed out:

Why is the table inserted after current block instead of splitting it (see v4 https://ckeditor.com/ckeditor-4/)? It's not very intuitive IMO.

[Reinmar]

That's not critical so I'm moving this out of iteration 18.

And as for expected result, please use model.insertContent() which will take care of handling situations like inserting this into an empty paragraph (should replace it) or into a block quote (should split p and bQ).

[Reinmar]

BTW, the uploadImage button does something similar now – it also finds the "optimal insertion position". This behaviour makes sense especially for the block toolbar (Letters-like implementation). So, I'd say that the table feature should work in the same way.

cc @oskarwrobel @pjasiun

[Reinmar]

See: https://github.com/ckeditor/ckeditor5-image/blob/076591e7f3b2eda73d172d6dcbabf8de3972aeba/src/imageupload/imageuploadui.js#L49-L53

[pjasiun]

Yep, we had a long discussion if an image insertion should break a block and agreed it should not, see https://github.com/ckeditor/ckeditor5-image/blob/076591e7f3b2eda73d172d6dcbabf8de3972aeba/src/imageupload/utils.js#L24-L38

However, image and tables are not exactly the same case. For images, we had mostly image drop in mind. It is hard to select position precisely when you drop, what was an argument to prevent block split. An image can be also aligned to the side, to be an illustration of the paragraph. To do so, the image needs to be inserted before the block. This is why the image is usually inserted before the block (except the case when the selection is at the end of the block).

In case of tables, I am not sure if they should break blocks. What I am sure, is that the table should be inserted before the block if the selection is at the beginning of the block. Otherwise, inserting tables using block toolbar will bring bad UX.

[pjasiun]

We added tables feature to Letters and now it is inconsistent that image is inserted before and table after the paragraph.

[pjasiun]

It is exceptionally bad when I insert into an empty paragraph: table feature leaves an empty paragraph instead of replacing it:

[Reinmar]

Just so you don't need to worry: model.insertContent() takes care of inserting into an empty paragraph.

We added tables feature to Letters and now it is inconsistent that image is inserted before and table after the paragraph.

And for that we need to expose the findOptimalInsertionPosition() from image upload utils. I wonder... where should it end? Maybe it could become a part of model.insertContent() itself? An option maybe?

[Reinmar]

But let's continue this discussion in #1243.