Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Unify widget insertion #111

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Unify widget insertion #111

merged 1 commit into from
Sep 18, 2018

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Sep 13, 2018

Suggested merge commit message (convention)

Other: Table feature should insert table the same way as other widgets. Closes ckeditor/ckeditor5#3181.

BREAKING CHANGE: The TableUtils#createTable() method now accepts model Writer instance instead of Position. The method no longer inserts created table to the model - use returned value instead.


Additional information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 99.52% when pulling 974478f on t/27 into 0a53042 on master.

@pjasiun pjasiun merged commit 77d96a4 into master Sep 18, 2018
@pjasiun pjasiun deleted the t/27 branch September 18, 2018 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The InsertTableCommand should break paragraph where the selection is anchored
3 participants