-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create initial implementation #4692
Comments
Should we be aware of such usage?
IMO yes, we should stack actions so the editor will be destroyed once it's created. cc @pjasiun. |
I think the editor could support it. If the editor does not support it, then watchdog should not add such functionally (as long as there is no special reason, valid for Watchdog, but not for the editor, why Watchdog should have such functionality). |
The watchdog has a slightly different API. Using the editor you can't do the above because you don't have access to the editor before the initialization. |
Right. Then, I think we could add such protection, but we can do it in the follow-up. |
Other: Added context as second required argument to the `CKEditorError`'s constructor, changed `isCKEditorError()` method to `is()`. Introduced the `areConnectedThroughProperties()` utility Part of the ckeditor/ckeditor5-watchdog#1.
Feature: Introduce Watchdog. Closes #1.
Overview created by @pjasiun:
CKEditorError
will occur it might be tricky to guess which editor causes the issue, the error could be thrown on themodel
class which knows nothing about theeditor
instance. However, since watchdog keeps the instance of theeditor
, it can recursively iterate over its own properties and check if the error is thrown on any of it.Full usage:
Shortcut:
Additional API:
The text was updated successfully, but these errors were encountered: