Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Do something with build samples #535

Closed
Reinmar opened this issue Sep 2, 2017 · 10 comments
Closed

[Docs] Do something with build samples #535

Reinmar opened this issue Sep 2, 2017 · 10 comments
Assignees
Labels
status:discussion type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 2, 2017

Every build has its sample/index.html. We need to decide whether we want to keep those and if so, improve them (e.g. use some generic, future-proof content).

@Reinmar Reinmar added candidate:1.0.0 status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". labels Sep 2, 2017
@Reinmar Reinmar added this to the iteration 12 milestone Sep 2, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Sep 2, 2017

cc @wwalc

@Reinmar Reinmar added type:docs This issue reports a task related to documentation (e.g. an idea for a guide). and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels Sep 2, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Sep 2, 2017

For now, these samples are not published on npm, so they are available only in the repository.

@wwalc
Copy link
Member

wwalc commented Sep 4, 2017

I believe we might want to bundle such sample when distributing builds as zip packages. We haven't decided yet what the structure of a zip file should be, but for the end users such included sample should be useful. It would make discovering on how to run the editor a no-brainer and would let users get a taste of it, without even having to look at the documentation.

So: 👍 for making the content of a sample future proof and generic.

The sample should not load any image - I was wondering if not to load something from CDN instead of "../tests/manual/sample.jpg, but not loading any resource would make it fully working without the internet connection.

If we include the sample in the zip package, we should possibly fix the path to the build file:

<script src="../build/ckeditor.js"></script>

@Reinmar
Copy link
Member Author

Reinmar commented Sep 4, 2017

The sample should not load any image - I was wondering if not to load something from CDN instead of "../tests/manual/sample.jpg, but not loading any resource would make it fully working without the internet connection.

I think that when you're offline you will accept and understand the fact that an image doesn't load. So using CDN makes sense for me.

@Reinmar
Copy link
Member Author

Reinmar commented Sep 4, 2017

If we include the sample in the zip package, we should possibly fix the path to the build file:

?

It's exactly this now:

<script src="../build/ckeditor.js"></script>

@wwalc
Copy link
Member

wwalc commented Sep 4, 2017

?

It's exactly this now:

<script src="../build/ckeditor.js"></script>

Ignore this, nvm. What I meant there that depending on the structure of the zip package (#541) it may or may not be okay.

@pomek
Copy link
Member

pomek commented Sep 21, 2017

Guys, could you provide some URL which we can use in the sample?

@wwalc
Copy link
Member

wwalc commented Sep 21, 2017

I think this issue can be closed as we decided not to include any sample in distributed zip packages. The included README file will serve as a starting point for anyone starting his journey with CKEditor.

@Reinmar
Copy link
Member Author

Reinmar commented Sep 26, 2017

The file is useful when rebuilding an editor (it lets you quickly validate the result). So it makes perfect sense to keep it in the repos. Of course, it won't be published on npm or in zip packages, but as we know this is a completely different set of files anyway.

So, I'll make some cleanup in this files and leave it there on GH.

@Reinmar Reinmar self-assigned this Sep 26, 2017
Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Sep 26, 2017
Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Sep 26, 2017
Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Sep 26, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Sep 26, 2017

I improved the files and mentioned that they can be used in 1506584.

@Reinmar Reinmar closed this as completed Sep 26, 2017
JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021
rivernews pushed a commit to rivernews/ckeditor5-build-balloon-2022 that referenced this issue Dec 31, 2021
fl01337 pushed a commit to fl01337/ckeditor-5-build-inline that referenced this issue May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:discussion type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Development

No branches or pull requests

3 participants