Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoformat should support strikethrough #6412

Closed
mlewand opened this issue Mar 11, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-autoformat#79
Closed

Autoformat should support strikethrough #6412

mlewand opened this issue Mar 11, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-autoformat#79
Assignees
@niegowski
Labels
intro Good first ticket. package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 31 (v19...

Comments

@mlewand
Copy link
Contributor

mlewand commented Mar 11, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

Currently autoformat does not support strikethrough. It should be possible to strikethrough text with ~~.

📃 Other details

  • Browser: Any
  • OS: Any

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:autoformat labels Mar 11, 2020
@mlewand mlewand added this to the backlog milestone Mar 11, 2020
@mlewand mlewand added the intro Good first ticket. label Mar 16, 2020
@mlewand
Copy link
Contributor Author

mlewand commented Mar 16, 2020

There are a bunch of basic style commands added in https://github.com/ckeditor/ckeditor5-autoformat/blob/871ad12b85fe59ade193b45b0c9fbc081515ac07/src/autoformat.js#L77-L107 but there's no binding for the strikethrough comand.

So we need to do a similar thing as for other (bold, italic, code) commands but for strikethrough and with different wrapper (~~).

Ofc this change needs to be covered with unit tests.

@niegowski
Copy link
Contributor

ckeditor/ckeditor5-autoformat#79

@niegowski niegowski mentioned this issue Mar 17, 2020
Merged
jodator added a commit to ckeditor/ckeditor5-autoformat that referenced this issue Mar 25, 2020
@jodator
Merge pull request #79 from ckeditor/i/6412
9c3fd3e 
Feature: Added strikethrough auto format support. Closes ckeditor/ckeditor5#6412.
@Reinmar Reinmar modified the milestones: backlog, iteration 31 Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
intro Good first ticket. package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

Feature: Strikethrough support. ckeditor/ckeditor5-autoformat
3 participants
@Reinmar @niegowski @mlewand