-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table properties balloon not displaying on cell multiselect in Balloon and Balloon Block editors #6443
Comments
So, the tl;dr is that on a multi-cell selection we should still see the table toolbar. Table toolbar should have precedence over the balloon toolbar in this case. |
But what I described above would make bold, italic and other inline options inaccessible in case of table cell selection, so you won't be avle to boild multiple cells at once. In other words, it's trade off and it's not a good one. We need to find a better solution from the UX perspective. |
Just to not forget: we already have one solution for conflicting items (balloon rotator). Maybe using it (if does not require a lot of effort) wouldn't be as bad as leaving users with a feature that just cannot be used. |
I stumbled upon this today again and I think we could raise the priority of this issue. This is pretty annoying. |
Solution: If there is more than one range in the selection, the contextual toolbar should not be displayed. I guess we don't check that currently and that makes the contextual toolbar displayed for multi-range table cell selections. |
Fix (ui): The `BalloonToolbar` should not show up when multiple objects (for instance, table cells) are selected at a time. Closes #6443.
📝 Provide detailed reproduction steps (if any)
Occurs on latest master
In Balloon editor you don't event need to add any text
✔️ Expected result
Table properties balloon shows up, you are able to edit a table
❌ Actual result
Editor balloon toolbar shows up, you can edit only content
Sample from Balloon Block editor:
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: