Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table properties balloon not displaying on cell multiselect in Balloon and Balloon Block editors #6443

Closed
FilipTokarski opened this issue Mar 16, 2020 · 5 comments · Fixed by #7378
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

Occurs on latest master

  1. Open Ballon or Balloon Block editor
  2. Select multiple cells ( with some text content )

In Balloon editor you don't event need to add any text

✔️ Expected result

Table properties balloon shows up, you are able to edit a table

❌ Actual result

Editor balloon toolbar shows up, you can edit only content

Sample from Balloon Block editor:
16_table1


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Mar 16, 2020
@Mgsy Mgsy added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed labels Mar 16, 2020
@mlewand mlewand added this to the iteration 31 milestone Mar 16, 2020
@Reinmar
Copy link
Member

Reinmar commented Mar 24, 2020

So, the tl;dr is that on a multi-cell selection we should still see the table toolbar. Table toolbar should have precedence over the balloon toolbar in this case.

@Reinmar Reinmar modified the milestones: iteration 31, nice-to-have Mar 24, 2020
@Reinmar
Copy link
Member

Reinmar commented Mar 24, 2020

But what I described above would make bold, italic and other inline options inaccessible in case of table cell selection, so you won't be avle to boild multiple cells at once. In other words, it's trade off and it's not a good one. We need to find a better solution from the UX perspective.

@Mgsy Mgsy added the support:1 An issue reported by a commercially licensed client. label Apr 24, 2020
@wwalc
Copy link
Member

wwalc commented Apr 27, 2020

Just to not forget: we already have one solution for conflicting items (balloon rotator). Maybe using it (if does not require a lot of effort) wouldn't be as bad as leaving users with a feature that just cannot be used.

@lslowikowska lslowikowska added support:2 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Apr 29, 2020
@Reinmar Reinmar modified the milestones: nice-to-have, next, iteration 32 May 4, 2020
@oleq
Copy link
Member

oleq commented May 12, 2020

I stumbled upon this today again and I think we could raise the priority of this issue. This is pretty annoying.

@Reinmar
Copy link
Member

Reinmar commented May 26, 2020

Solution: If there is more than one range in the selection, the contextual toolbar should not be displayed. I guess we don't check that currently and that makes the contextual toolbar displayed for multi-range table cell selections.

@Reinmar Reinmar modified the milestones: next, iteration 33 May 26, 2020
@tomalec tomalec self-assigned this Jun 1, 2020
@oleq oleq assigned niegowski and unassigned tomalec Jun 4, 2020
@oleq oleq closed this as completed in #7378 Jun 5, 2020
oleq added a commit that referenced this issue Jun 5, 2020
Fix (ui): The `BalloonToolbar` should not show up when multiple objects (for instance, table cells) are selected at a time. Closes #6443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants