Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge cells command should not merge cells from column header with other cells #6521

Closed
jodator opened this issue Apr 1, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#306
Closed

Merge cells command should not merge cells from column header with other cells #6521

jodator opened this issue Apr 1, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#306
Assignees
@jodator
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@jodator
Copy link
Contributor

jodator commented Apr 1, 2020

📝 Provide detailed reproduction steps (if any)

Found here: ckeditor/ckeditor5-table#290 (comment).

image

and some weird result

image

✔️ Expected result

The command should be disabled like other merge cell commands.

❌ Actual result

You can merge cells from column header with other cells.

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Apr 1, 2020
@jodator jodator added this to the iteration 31 milestone Apr 1, 2020
@jodator jodator self-assigned this Apr 1, 2020
@jodator jodator mentioned this issue Apr 1, 2020
Merged
@jodator jodator self-assigned this Apr 20, 2020
@jodator jodator mentioned this issue Apr 20, 2020
Merged
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 22, 2020
@oleq
Merge pull request #306 from ckeditor/i/6521
856889e 
Internal: The `MergeCellsCommand` should not merge the heading column cells with other cells. Closes ckeditor/ckeditor5#6521.
@jodator jodator mentioned this issue Apr 24, 2020
Closed
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #306 from ckeditor/i/6521
0246156 
Internal: The `MergeCellsCommand` should not merge the heading column cells with other cells. Closes #6521.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6521: Add check for heading columns in merge cells command. ckeditor/ckeditor5-table
1 participant
@jodator