-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The .ck-labeled-input occurrences across the project should be reviewed and replaced with .ck-labeled-view #6553
Comments
A regression after #6110. Probably comes down to diff --git a/theme/ckeditor5-link/linkform.css b/theme/ckeditor5-link/linkform.css
index 970d54d..a9778cc 100644
--- a/theme/ckeditor5-link/linkform.css
+++ b/theme/ckeditor5-link/linkform.css
@@ -74,7 +74,7 @@
padding: 0;
min-width: var(--ck-input-text-width);
- & .ck-labeled-input {
+ & .ck-labeled-view {
margin: var(--ck-spacing-standard) var(--ck-spacing-standard) var(--ck-spacing-small);
& .ck-input-text { because it worked for me. Still I see many places across the codebase where I just realised that things don't work and we have problems in other places too: So all occurrences of |
Besides, why is it |
I'll check it.
The right class should be |
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` . Closes ckeditor/ckeditor5#6553.
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` . Closes #6553.
📝 Provide detailed reproduction steps (if any)
No idea why but I tried to add link decorators in one of our manual tests and the balloon doesn't have padding:
I saw this bug in the past but I don't know when and how we got rid of it. For some reason, it's back.
For the reference, this is how it should look like:
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: