Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The .ck-labeled-input occurrences across the project should be reviewed and replaced with .ck-labeled-view #6553

Closed
Reinmar opened this issue Apr 3, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-ui#553
Assignees
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 3, 2020

📝 Provide detailed reproduction steps (if any)

No idea why but I tried to add link decorators in one of our manual tests and the balloon doesn't have padding:

I saw this bug in the past but I don't know when and how we got rid of it. For some reason, it's back.

For the reference, this is how it should look like:


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Apr 3, 2020
@oleq oleq added the type:regression This issue reports a bug that was not present in the previous releases. label Apr 6, 2020
@Reinmar Reinmar added this to the iteration 31 milestone Apr 6, 2020
@oleq oleq added the package:ui label Apr 6, 2020
@oleq
Copy link
Member

oleq commented Apr 6, 2020

A regression after #6110. Probably comes down to

diff --git a/theme/ckeditor5-link/linkform.css b/theme/ckeditor5-link/linkform.css
index 970d54d..a9778cc 100644
--- a/theme/ckeditor5-link/linkform.css
+++ b/theme/ckeditor5-link/linkform.css
@@ -74,7 +74,7 @@
          padding: 0;
          min-width: var(--ck-input-text-width);

-         & .ck-labeled-input {
+         & .ck-labeled-view {
                   margin: var(--ck-spacing-standard) var(--ck-spacing-standard) var(--ck-spacing-small);

                   & .ck-input-text {

because it worked for me. Still I see many places across the codebase where .ck-labeled-input is used (which should be deprecated as a part of LabeledInputView), so I'm lost. How is that things work now? Which is the right class selector, @panr?


I just realised that things don't work and we have problems in other places too:

image

So all occurrences of .ck-labeled-input should be reviewed and fixed.

@oleq oleq changed the title The link balloon doesn't have padding when decorators are enabled The .ck-labeled-input occurrences across the project should be reviewed and replaced with .ck-labeled-view Apr 6, 2020
@oleq
Copy link
Member

oleq commented Apr 6, 2020

Besides, why is it .ck-labeled-view now when the class is LabeledFieldView? I couldn't understand where it came from.

@panr
Copy link
Contributor

panr commented Apr 6, 2020

I'll check it.

Which is the right class selector, @panr?

The right class should be ck-labeled-field-view and I made a mistake, when was changing globally all matching classes... I had turned off CSS files from global search in VSCode... 😞

oleq added a commit to ckeditor/ckeditor5-link that referenced this issue Apr 8, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
oleq added a commit to ckeditor/ckeditor5-ui that referenced this issue Apr 8, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
oleq added a commit to ckeditor/ckeditor5-image that referenced this issue Apr 8, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
oleq added a commit to ckeditor/ckeditor5-media-embed that referenced this issue Apr 8, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 8, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see ckeditor/ckeditor5#6553).
oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Apr 8, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` . Closes ckeditor/ckeditor5#6553.
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` . Closes #6553.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants