Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolbarView should handle items grouping correctly when invisible #6575

Closed
oleq opened this issue Apr 8, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-ui#554
Closed

ToolbarView should handle items grouping correctly when invisible #6575

oleq opened this issue Apr 8, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-ui#554
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Apr 8, 2020

📝 Provide detailed reproduction steps (if any)

  1. The grouping should never happen if the toolbar is invisible. Because it always leads to all items groped and weird things when other features (like positioning algorithm) when they see the toolbar in such state

image

  1. The grouping that was triggered by changing ToolbarView#maxWidth when toolbar is invisible should be queued so the next time the toolbar shows up (ResizeObserver kicks in automatically), the items are re-grouped. This is a problem when maxWidth increased because there's no pressure to ungroup the items when the toolbar showed up.

Related to #6449.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Apr 8, 2020
@oleq oleq added this to the iteration 31 milestone Apr 8, 2020
@oleq oleq self-assigned this Apr 8, 2020
This was referenced Apr 8, 2020
Merged
Closed
oleq added a commit to ckeditor/ckeditor5-ui that referenced this issue Apr 9, 2020
@oleq
Merge pull request #554 from ckeditor/i/6449
fcd9c4e 
Feature: The `BlockToolbar` should group items when there is no place to show them all. Closes ckeditor/ckeditor5#6449. Closes ckeditor/ckeditor5#6575. Closes ckeditor/ckeditor5#6570.

Bulletproofed the `ToolbarView#maxWidth` and items grouping when the toolbar is invisible.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #554 from ckeditor/i/6449
8f68da1 
Feature: The `BlockToolbar` should group items when there is no place to show them all. Closes #6449. Closes #6575. Closes #6570.

Bulletproofed the `ToolbarView#maxWidth` and items grouping when the toolbar is invisible.
@oleq oleq mentioned this issue Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

i/6449: Make block toolbar groupable ckeditor/ckeditor5-ui
1 participant
@oleq