Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Select all feature could expand selection with successive Ctrl+A keystrokes #6621

Closed
oleq opened this issue Apr 16, 2020 · 0 comments · Fixed by #6816
Closed

The Select all feature could expand selection with successive Ctrl+A keystrokes #6621

oleq opened this issue Apr 16, 2020 · 0 comments · Fixed by #6816
Assignees
@tomalec
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:select-all type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 33 (v20...

Comments

@oleq
Copy link
Member

oleq commented Apr 16, 2020

📝 Provide a description of the improvement

The idea is as follows:

  1. Consider the following structure root->table->cell->image->caption.
  2. The selection is collapsed in a caption.
  3. Ctrl+A to select the image caption.
  4. Ctrl+A to select the image.
  5. Ctrl+A to select the cell content (if the image is not already its only content).
  6. Ctrl+A to select the entire table.
  7. Ctrl+A to select the entire root.

Alternatively, the scenario could work without 4. and 6. because it feels like a widget responsibility.

The idea was first described in the original PR.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. intro Good first ticket. package:select-all labels Apr 16, 2020
@oleq oleq mentioned this issue Apr 16, 2020
Merged
@oleq oleq added the domain:ui/ux This issue reports a problem related to UI or UX. label Apr 16, 2020
@Reinmar Reinmar modified the milestones: backlog, iteration 32 Apr 17, 2020
tomalec added a commit that referenced this issue May 13, 2020
@tomalec
Select all in parent limit elements for successive select-all commands.
0c1d2e6 
Closes #6621.
@tomalec tomalec mentioned this issue May 14, 2020
Merged
tomalec added a commit that referenced this issue May 24, 2020
@tomalec
Select-all only in limit elements which accept text and paragraphs,
bd301c4 
as suggested in reviews
#6816 (comment) and
#6816 (review) .
Closes #6621.
@Reinmar Reinmar modified the milestones: iteration 32, next, iteration 33 May 25, 2020
oleq added a commit that referenced this issue May 28, 2020
@oleq
Merge pull request #6816 from ckeditor/i/6621-select-all
6f59c78 
Other: Improved the select-all feature so that it includes more and more content if the selection was anchored in a nested editable. Closes #6621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomalec tomalec

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:select-all type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

#6621: Select all in parent limit elements for successive select-all commands. ckeditor/ckeditor5
3 participants
@tomalec @Reinmar @oleq