Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting column as header should split it col-spaned cells #6658

Closed
jodator opened this issue Apr 24, 2020 · 1 comment · Fixed by #7226
Closed

Setting column as header should split it col-spaned cells #6658

jodator opened this issue Apr 24, 2020 · 1 comment · Fixed by #7226
Assignees
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Apr 24, 2020

📝 Provide detailed reproduction steps (if any)

  1. Merge two or more table cells at the beginning of a row.
  2. Set column heading on merged cell.

✔️ Expected result

The behavior should follow the logic for setting heading rows - it should split col-spanned cells which spans extends over the column heading section.

❌ Actual result

The restriction is not applied.

Note that creating an identical table is not possible using merge cells and merge (right/left) cell commands.

Possible solution

For better UX when selection is in cells that are already merged I can see two options:

  1. We use it's column and split the merged cell.
  2. We set heading over columns that this cell spans.
Case 1: split selected cellCase 2: Extend heading rows

For case 2: Any other merged cell (apart from selected) should not extend the heading section and should be split.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Apr 24, 2020
@mlewand mlewand added this to the backlog milestone Apr 27, 2020
@jodator jodator self-assigned this May 16, 2020
@jodator
Copy link
Contributor Author

jodator commented May 16, 2020

Utility for this is created in #6121.

@jodator jodator modified the milestones: backlog, iteration 32 May 16, 2020
@jodator jodator changed the title Seting column as header should split it col-spaned cells Setting column as header should split it col-spaned cells May 19, 2020
niegowski added a commit that referenced this issue May 20, 2020
Internal (table): Handle spanned table cells in pasting scenarios. Closes #6122.

Fix (table): Setting column as header will now split col-spanned cells. Closes #6658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants