Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain the repository of elements which need a magic block #6688

Closed
oleq opened this issue Apr 28, 2020 · 0 comments · Fixed by #6794
Closed

Maintain the repository of elements which need a magic block #6688

oleq opened this issue Apr 28, 2020 · 0 comments · Fixed by #6794
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:widget squad:magic type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 32 (v19...

Comments

@oleq
Copy link
Member

oleq commented Apr 28, 2020 •
edited
Loading

This should probably be done in a view post-fixer. For instance, as 2 maps containing elements with MB before and after.

In the initial implementation only the widgets are taken into consideration. So all we need is a list of all widgets that have display: block from getComputedStyle() (because there could be inline widgets too).

A piece of #407.
@oleq oleq added the domain:ui/ux This issue reports a problem related to UI or UX. label Apr 28, 2020
@oleq oleq added this to the iteration 32 milestone Apr 28, 2020
@oleq oleq changed the title Maintain the repository of elements which need a magic block before/after Maintain the repository of elements which need a magic block Apr 28, 2020
@Reinmar Reinmar added package:magic-block type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels May 1, 2020
@oleq oleq self-assigned this May 5, 2020
@oleq oleq mentioned this issue May 12, 2020
Merged
Reinmar added a commit that referenced this issue May 14, 2020
@Reinmar
Merge pull request #6794 from ckeditor/i/407-simple
dbf24a2 
Feature (widget): Brought the feature allowing users to type in tight spots around block widgets where web browsers do not allow the caret to be placed (see #407). Closes #6740. Closes #6688. Closes #6689. Closes #6695.

Internal (horizontal-line): Updated the styling of .ck-horizontal-line from overflow: hidden to display: flow-root to allow the typing around UI inside the widgets (see #407, #6795).

Tests (image): Updated various image test to take the widget typing around feature into account (see #407).

Fix (media-mebed): The media widget conversion should not discard widget internals (drag or resize handlers, buttons to insert paragraphs, etc.) injected by other features when converting the URL (see #407).

Feature (theme-lark): Brought styles for the feature allowing users to type in tight spots around block widgets (see #407).

MINOR BREAKING CHANGE: The new --ck-color-focus-border-coordinates CSS custom property has been added and the existing --ck-color-focus-border property now uses it internally. If your integration overrides the latter, we recommend you update the former to avoid compatibility issues with various editor UI features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:widget squad:magic type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 32 (v19.1.0)
2 participants
@Reinmar @oleq