Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow linking images - UI #7331

Closed
jodator opened this issue May 29, 2020 · 1 comment · Fixed by #7452
Closed

Allow linking images - UI #7331

jodator opened this issue May 29, 2020 · 1 comment · Fixed by #7452
Assignees
@panr
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image package:link type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 33 (v20...

Comments

@jodator
Copy link
Contributor

jodator commented May 29, 2020 •
edited
Loading

📝 Provide a description of the new feature

Introduce link UI to image toolbar. Some research is needed to check the proper implementation.

  • link button should be enabled on images (it is now by coincidence)
  • use the the main toolbar button
  • could it be used in image toolbar (check only)

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@jodator jodator added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:image package:link domain:ui/ux This issue reports a problem related to UI or UX. squad:blue labels May 29, 2020
@jodator jodator added this to the iteration 33 milestone May 29, 2020
@jodator jodator mentioned this issue May 29, 2020
Closed
@jodator
Copy link
Contributor Author

jodator commented Jun 15, 2020

From sync:

  • add linkImage UI element to be used image toolbar (encapsulate the switch logic)

@panr panr mentioned this issue Jun 17, 2020
Merged
oleq added a commit that referenced this issue Jun 18, 2020
@oleq
Merge pull request #7452 from ckeditor/i/7331
878257e 
Feature (link): Introduced the `LinkImageUI` plugin that brings a UI to wrap images in links. Closes #7331.

Internal (image): Reduced unnecessary margin under a linked image. See #7452 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image package:link type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

i/7331: Introduce LinkImageUI ckeditor/ckeditor5
2 participants
@jodator @panr