Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+tab in the first table cell does nothing #7535

Closed
mlewand opened this issue Jul 2, 2020 · 2 comments · Fixed by #7765
Closed

Shift+tab in the first table cell does nothing #7535

mlewand opened this issue Jul 2, 2020 · 2 comments · Fixed by #7765
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:table squad:core Issue to be handled by the Core team. status:discussion support:3 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 2, 2020

📝 Provide detailed reproduction steps (if any)

  1. Go to the table sample https://ckeditor.com/docs/ckeditor5/19.0.0/features/table.html
  2. Place the caret in the first cell.
  3. Press shift+tab.

✔️ Expected result

I'd like to discuss expected behavior, currently I'm keen to think that it should move cursor before the table.

This will be consistent with other widgets, e.g. image:

❌ Actual result

Nothing happens.

📃 Other details

Reproducible at least since 16.0.0.

  • Browser: Chrome, Firefox (didn't check others)

As a workaround one could use up / left arrows to get outside of the table.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. status:discussion package:table domain:ui/ux This issue reports a problem related to UI or UX. domain:accessibility This issue reports an accessibility problem. squad:table support:1 An issue reported by a commercially licensed client. labels Jul 2, 2020
@mlewand mlewand added this to the backlog milestone Jul 27, 2020
@jodator jodator added squad:dx squad:core Issue to be handled by the Core team. labels Jul 28, 2020
@Reinmar
Copy link
Member

Reinmar commented Jul 28, 2020

Our long-term plans for navigating in/out of nested editables is to use other keys (there's a separate ticket for that). But we can resolve this issue (Shift+Tab) in the meantime as the long-term solution will not be implemented anytime soon.

@niegowski niegowski self-assigned this Aug 3, 2020
@niegowski niegowski modified the milestones: backlog, iteration 35 Aug 3, 2020
@niegowski
Copy link
Contributor

I'd like to discuss expected behavior, currently I'm keen to think that it should move cursor before the table.

This will be consistent with other widgets, e.g. image:

How this works with image captions is a default browser behavior - Tab navigates to next editable (and this is different in Chrome and in Firefox). I would adjust it with arrow keys handling so Shift+Tab in the first table cell would select the whole table widget.

pomek added a commit that referenced this issue Aug 4, 2020
Other (table): The whole table should be selected on the <kbd>Shift</kbd>+<kbd>Tab</kbd> press in the first table cell. Closes #7535.
@lslowikowska lslowikowska added support:3 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:table squad:core Issue to be handled by the Core team. status:discussion support:3 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants