Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update marked dependency #7850

Closed
jodator opened this issue Aug 17, 2020 · 2 comments · Fixed by #7859
Closed

Update marked dependency #7850

jodator opened this issue Aug 17, 2020 · 2 comments · Fixed by #7859
Labels
package:markdown-gfm type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 35 (v22...

Comments

@jodator
Copy link
Contributor

jodator commented Aug 17, 2020

Provide a description of the task

Follow-up for the #7307. The currently used version in 0.7.0 and the latest one is 1.1.1. I've changed the version to 0.8.2 and the tests passed but it would be nice to test the upgrade in a real-world scenario.

@fredck could you check and/or confirm that upgrade to 1.1.1 would be safe?
@jodator jodator added type:task This issue reports a chore (non-production change) and other types of "todos". package:markdown-gfm squad:dx labels Aug 17, 2020
@jodator jodator added this to the next milestone Aug 17, 2020
@fredck
Copy link
Contributor

fredck commented Aug 17, 2020

@fredck could you check and/or confirm that upgrade to 1.1.1 would be safe?

The PR that introduced Marked v1.0.0 contains the following:

The only users that will need to change their code are users who are extending the lexer or parser currently.

We're indeed doing so, therefore we need to adapt the code to their newly introduced API.

Apart from that, once our tests pass, we should be good to go with it.

@fredck fredck mentioned this issue Aug 17, 2020
Merged
@fredck
Copy link
Contributor

fredck commented Aug 17, 2020

I've pushed a PR that starts he upgrade to v1.1.1.

I've added some questions to the PR though, so it's not ready to go still.

jodator added a commit that referenced this issue Aug 18, 2020
@jodator
Merge pull request #7859 from ckeditor/i/7850
d6c8731 
Other (markdown-gfm): Upgraded to Marked v1.1.1. Closes #7850.
@mlewand mlewand modified the milestones: next, iteration 35 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:markdown-gfm type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 35 (v22.0.0)
Development

Successfully merging a pull request may close this issue.

Upgraded to Marked v1.1.1 ckeditor/ckeditor5
3 participants
@jodator @fredck @mlewand