-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should toolbar have a gradient? #805
Comments
A follow-up of #645. |
I don't like gradient. It looks a bit weird when you hover over icon - the contrast near top of the icon is different than on the below. |
For me, that gradient in toolbar looks like something is not rendered properly. Also gradient is not working good with states of buttons + arrows in balloons. IMHO we should try to decide one color, like Edit: @Reinmar I've meant |
#dadada is a bit too dark IMO... OTOH, https://www.youtube.com/watch?v=lNYcviXK4rg |
BTW, if we'd remove the gradient and go with a light background then the borders stand out too much. Is the contrast between borders and the toolbar background important for a11y? |
Not much. It's more about the design. |
This is a good point. There are, however, many kind of apps to which CKEditor will be injected. I guess you can't look ideal in all of them. From the two screenshot of CKEditor 5 in Drupal 8 I'm totally ok with both. I guess that the same will be for Wordpress, Neos or whatever else you'd try. Moreover, developers who will be integrating CKEditor 5 into these apps will be able to easily adjust the colors and gradients and everything. Which means that we fully satisfy this requirement (for CKE to be easy to integrate). What matters now, the most, is the initial look of CKEditor 5 on our websites (docs and ckeditor.com). I'd actually focus on these, if we're talking about putting things into perspective. |
Interestingly, this gradient is far less visible on my MB Pro than on my Dell external LCD. On my MB Pro it looks good :D I reported the issue when working on the Dell monitor. |
My feeling is that a gradient is a bit out of fashion. WDYT?
The text was updated successfully, but these errors were encountered: