Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active button's style is a bit boring #814

Closed
Reinmar opened this issue Feb 5, 2018 · 5 comments
Closed

Active button's style is a bit boring #814

Reinmar opened this issue Feb 5, 2018 · 5 comments
Assignees
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 5, 2018

image

The simple, rounded grey square looks somehow dull in comparison to these icons. Also, the gradient (which I actually don't like #805) strengthen this, IMO.

Previously it was the same:

image

But due to a darker and plain toolbar color it matched better.

Some ideas for this style:

  • remove the gradient :P
  • add some gradient/box-shadow to an active button
  • use slightly lighter color

PS. The current style looks the worst when used in a dropdown:

image

@Reinmar
Copy link
Member Author

Reinmar commented Feb 5, 2018

One thing could be to use opacity + color so the button blends better with the gradient. Although... difference is minimal :D

image

image

@oleq oleq added this to the iteration 14 milestone Feb 14, 2018
@oleq oleq self-assigned this Feb 14, 2018
@Reinmar
Copy link
Member Author

Reinmar commented Feb 14, 2018

We need to remember here that there must a contrast between hover and active style of a button.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 27, 2018

I got used to these buttons. And they are less of a problem for me once we dropped the gradient. I'd be fine with ignoring this.

@oleq oleq modified the milestones: iteration 14, iteration 15 Mar 1, 2018
@oleq
Copy link
Member

oleq commented Mar 1, 2018

Moved to the next iteration. We'll have more time to gather the feedback.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 30, 2018

I got used to it. And it looks better now, when there's no gradient. So, from my POV it's ok.

@Reinmar Reinmar closed this as completed Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants