-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget - hide selection handle for nested widget #10556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one comment/suggestion to consider.
Also I'm pretty sure we need to add a test to cover scenario with multiple ranges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's circle back a little bit. There's a decision concerning UX we must make before we jump to writing code. I'm moving the discussion to the original issue #9491 (comment) where I listed possible scenarios.
I've just pushed suggested changes to tableselection.css. |
@ckeditor/qa-team Can you give us a hand, please? 🙏 You can find inspiration in comments #9491 🙃 |
packages/ckeditor5-theme-lark/theme/ckeditor5-table/tableselection.css
Outdated
Show resolved
Hide resolved
Not sure if important. 0_table1.mp4 |
Let's address it in a separate issue. |
@dawidurbanski I don't feel like reviewing a solution I suggested myself. Can you do the review please? BTW: What's going on with the CI? |
Hmm, build details: |
Apart from the comment above, I didn't find anything else. |
There's something wrong with the CI then. Don't worry. |
It decreases the CC. Restarting a build usually helps. |
@oleq done @EwelinaD I requested one last change. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Suggested merge commit message (convention)
Fix (table): Selected nested widget in table selection has no longer outline and selection handle. Closes #9491.
Additional information
Fix is based on assumption that there are multiple ranges during data selection in table.