CKBox: Update configuration options passed down to CKBox instance by ckbox-plugin #16473
Conversation
| height: number; | ||
| }; | ||
|
|
||
| export type CKBoxCategories = { |
There was a problem hiding this comment.
Why export type if the config uses export interface? Seems like an unnecessary inconsistency.
| }; | ||
| }; | ||
|
|
||
| export type CKBoxView = { |
There was a problem hiding this comment.
Why export type if the config uses export interface? Seems like an unnecessary inconsistency.
| hideMaximizeButton: boolean; | ||
| }; | ||
|
|
||
| export type CKBoxUpload = { |
There was a problem hiding this comment.
Why export type if the config uses export interface? Seems like an unnecessary inconsistency.
| const dialog = ckboxConfig.dialog!; | ||
| const categories = ckboxConfig.categories!; | ||
| const view = ckboxConfig.view!; | ||
| const upload = ckboxConfig.upload!; | ||
|
|
There was a problem hiding this comment.
Why not-null assertions (!)? Below, there are guards (like dialog && dialog.with) for each of those values.
There was a problem hiding this comment.
I don't know certainly why, but I afraid ckboxConfig.dialog!.width! is not valid. I tried it out and tests are crushed with that expression.
|
Please change the suggested comment message. |
Suggested merge commit message (convention)
Feature (ckbox): Added more configuration options passed down to the CKBox. Closes #3695
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.