No longer crash editor after removing link from image when LinkConfig#addTargetToExternalLinks is enabled
#17281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g#addTargetToExternalLinks: true` is enabled
Mati365
changed the title
LinkConfig#addTargetToExternalLinks: true is enabledLinkConfig#addTargetToExternalLinks is enabled
niegowski
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (link): No longer crash editor after removing link from image when
LinkConfig#addTargetToExternalLinks: trueis set. Closes #17252Additional information
Decorator responsible for attaching some of the attributes enabled by
addTargetToExternalLinksis executed after downcast dispatcher responsible for removingaelements inside<figure class="image ..."element. It caused the crash, because dispatchergetDispatcherForLinkedImageassumed that image is always present in decorated element. Dispatcher responsible for removingatags is defined indowncastImageLink#221inlink/linkimageediting.tsfile.I did not change priority of dispatchers to avoid other regressions and changes in public API.