Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I/6333: Create MediaFormView for each dropdown instance separately #6736

Merged
merged 4 commits into from
May 5, 2020
Merged

I/6333: Create MediaFormView for each dropdown instance separately #6736

merged 4 commits into from
May 5, 2020

Conversation

tomalec
Copy link
Contributor

@tomalec tomalec commented May 4, 2020

Suggested merge commit message (convention)

Fix (media-embed): Create MediaFormView for each dropdown instance separately. Closes #6333.

MINOR BREAKING CHANGE: mediaembedui~MediaEmbedUI#form was removed from the API

Additional information

Moved from ckeditor/ckeditor5-media-embed#98

@tomalec tomalec mentioned this pull request May 5, 2020
Closed
@Reinmar Reinmar merged commit 3011e37 into master May 5, 2020
@Reinmar Reinmar deleted the i/6333 branch May 5, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor crashes after inserting two mediaEmbed items to the toolbar
2 participants
@tomalec @Reinmar