Fix #7958 by checking for valid firstChild.
#7959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Hi @tomi-bigpi! Thanks for the PR. All looks good and pasting empty list item from GDocs works 🎉
Note that I didn't include an HTML file named
empty-list-item.html
I don't recall now how those should be constructed but big thanks for adding a good test for this case :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (paste-from-office): Fix list paste from Google Docs with empty item. Closes #7958.
Additional information
Note that I didn't include an HTML file named
empty-list-item.htmlunderpackages/ckeditor5-paste-from-office/tests/_data/paste-from-google-docs/lists/empty-list-itemas I couldn't find any references to the use in the other fixtures that had that corresponding file.