-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autosave plugin not ignoring transparent
type events
#9234
Conversation
Hi @asimkt, Thanks for the PR and I'm really sorry for the late response. I'll review it soon. |
Thanks @ma2ciek |
Hi @asimkt! Our team would like to discuss with you the proposed solution, so it would be appreciated if you could contact us through our support channel. Thanks! |
Some further discussion can be found in the referenced issue comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying out, unfortunately as described in #9233 (comment) this is not the proper way to fix it as it will have multiple undesired side effects.
That being said there are other ideas to solve it #9233 (comment) maybe this will be helpful.
As such I'm closing the PR if you'd like to try a different approach feel free to open a new PR.
I can see we already have a fix. Do you want to close this PR @AnnaTomanek ? IDK why we re-opened this one. |
There has been no activity on this PR for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the contribution, leave a comment or reaction under this PR. |
We've closed your PR due to inactivity over the last year. While time has passed, the core of your contribution might still be relevant. If you're able, consider reopening a similar PR. |
Fix: autosave plugin not ignoring
transparent
type events. Closes #9233.Additional information
Considering all transparent events can be safely ignored by autosave feature as mentioned in https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_model_batch-Batch.html#member-type