Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): dependency housekeeping #144

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

saiintbrisson
Copy link
Contributor

@saiintbrisson saiintbrisson commented Aug 17, 2023

This change performs some housekeeping activities such as disabling unneeded dependency features.

The renaming from bigdecimal_rs to bigdecimal-rs was done to comply with the bigdecimal repository name (bigdecimal-rs), this shouldn't be breaking as it does not have any impact since the feature flag for the impl was wrong and required bigdecimal instead of bigdecimal_rs.

I also believe the bigdecimal feature flag which enables both bigdecimal and rust_decimal should be deprecated in favor of enabling the specific feature flags manually, but this would be a breaking change and requires a new major version.

Important

Bumped fake to 2.8 and dummy to 0.6.

@@ -1,6 +1,6 @@
//! This module contains implementations of `Dummy` trait

#[cfg(feature = "bigdecimal")]
#[cfg(feature = "bigdecimal-rs")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows for the use of bigdecimal-rs directly without needing to enable rust_decimal as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved clippy errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the Cargo.lock file to prevent possible dependency mismatches between dev environments, but this is not required.

@cksac cksac merged commit b12666e into cksac:master Aug 18, 2023
5 checks passed
@saiintbrisson
Copy link
Contributor Author

Hi @cksac! Sorry for the inconvenience, but could you please publish the new versions for fake and dummy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants