Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BurntSushi Tests Fail due to deprecation in go get #62

Closed
mcb2003 opened this issue Oct 25, 2021 · 5 comments · Fixed by #64
Closed

BurntSushi Tests Fail due to deprecation in go get #62

mcb2003 opened this issue Oct 25, 2021 · 5 comments · Fixed by #64

Comments

@mcb2003
Copy link

mcb2003 commented Oct 25, 2021

When running test1/build.sh, go outputs the following notice:

$ bash build.sh 
go get: installing executables with 'go get' in module mode is deprecated.
	Use 'go install pkg@version' instead.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

As expected, running run.sh after this fails:

$ bash run.sh 
run.sh: line 5: ./toml-test: No such file or directory
@cktan
Copy link
Owner

cktan commented Oct 25, 2021

I will check it out...

@cktan
Copy link
Owner

cktan commented Oct 25, 2021

I was able to run with go version 1.16.

FYI, the burnt sushi tests are a bit outdated, and I may drop them soon.
E.g. v1 toml allows mixed types arrays, but burnt sushi thanks they should not be allowed.

Test: array-mixed-types-arrays-and-ints (invalid)

Expected an error, but no error was reported.

Test: array-mixed-types-ints-and-floats (invalid)

Expected an error, but no error was reported.

Test: array-mixed-types-strings-and-ints (invalid)

Expected an error, but no error was reported.

@mcb2003
Copy link
Author

mcb2003 commented Oct 25, 2021

I'm on go version go1.17.2 linux/amd64

@mcb2003
Copy link
Author

mcb2003 commented Oct 26, 2021

FYI, the burnt sushi tests are a bit outdated, and I may drop them soon. E.g. v1 toml allows mixed types arrays, but burnt sushi thanks they should not be allowed.

I see. No problem then.

@marzer
Copy link

marzer commented Nov 5, 2021

FYI, the burnt sushi tests are a bit outdated, and I may drop them soon. E.g. v1 toml allows mixed types arrays, but burnt sushi thanks they should not be allowed.

That is no longer true as the project has a new maintainer. It is now regularly updated and tests many TOML v1.0 features.

In fact, the recent discussion on this issue on toml-lang/toml suggests that the newly-maintained BurntSushi/toml-test will actually come to serve as the 'official' one in some capacity.

moorereason added a commit to moorereason/tomlc99 that referenced this issue Nov 23, 2021
@cktan cktan closed this as completed in #64 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants