test: use assert.ErrorIs()

clambin · Jan 23, 2023 · 05f0d56 · 05f0d56
1 parent 9c8d38b
commit 05f0d56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/pkg/mediaclient/plex/plex_test.go b/pkg/mediaclient/plex/plex_test.go
@@ -2,7 +2,6 @@ package plex_test
 
 import (
 	"context"
-	"errors"
 	"github.com/clambin/mediamon/pkg/mediaclient/plex"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -99,7 +98,7 @@ func TestPlexClient_Authentication_Failure(t *testing.T) {
 
 	_, err := c.GetIdentity(context.Background())
 	require.Error(t, err)
-	assert.True(t, errors.Is(err, unix.ECONNREFUSED))
+	assert.ErrorIs(t, err, unix.ECONNREFUSED)
 }
 
 func TestClient_Failures(t *testing.T) {
@@ -122,7 +121,7 @@ func TestClient_Failures(t *testing.T) {
 	testServer.Close()
 	_, err = c.GetIdentity(context.Background())
 	require.Error(t, err)
-	assert.True(t, errors.Is(err, unix.ECONNREFUSED))
+	assert.ErrorIs(t, err, unix.ECONNREFUSED)
 }
 
 // Server handlers

diff --git a/pkg/mediaclient/transmission/transmission.go b/pkg/mediaclient/transmission/transmission.go
@@ -61,8 +61,7 @@ func (client *Client) call(ctx context.Context, method string, response interfac
 
 		switch resp.StatusCode {
 		case http.StatusOK:
-			decoder := json.NewDecoder(resp.Body)
-			err = decoder.Decode(response)
+			err = json.NewDecoder(resp.Body).Decode(response)
 			answer = true
 		case http.StatusConflict:
 			// Transmission-Session-Id has expired. Get the new one and retry