Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0-0.2.0: Enhancement - Connection Options #99

Merged
merged 8 commits into from
Jan 31, 2023

Conversation

lnbc1QWFyb24
Copy link
Member

This PR adds to ability to customise the way that the app will connect to a node. A direct WebSocket connection can be made to the node either with TLS or without. A custom WebSocket proxy server can also be set, so that now the Clams proxy is not a single point of failure.

Also included in this PR is a performance improvement for fetching initial data. The requests have been parallelised as Lnmessage can now handle it without having issues decoding responses.

TESTING

I will add these instructions to docs as well, since this is a great way to test the app locally with a regtest node.

  1. Download Polar
  2. Create a test network with a least one CoreLN node running > v0.12.0 and start the network
  3. Open up the Docker dashboard and find the running container. Open up the docker compose file in your text editor: Screen Shot 2023-01-31 at 7 24 30 am
  4. Find the name of the CoreLN node and add --experimental-websocket-port=7272 to the startup command and expose the port: Screen Shot 2023-01-31 at 7 26 18 am
  5. Save the file and restart the Polar network
  6. Run the clams app locally without TLS by running yarn dev-http
  7. Enter the connection address using the public key of the node which is accessible from the "info" tab as well as localhost:7272.
  8. Click the "Advanced" dropdown -> select direct connection -> select ws: Screen Shot 2023-01-31 at 7 33 35 am
  9. Click "Connect" and you should successfully connect to the local node.
  10. To create an auth rune, click the "Actions" tab -> click "Launch which will launch a terminal window for the lightning CLI.
  11. Run lightning-cli commando-rune to create a rune and paste it in to the app.

Copy link
Contributor

@johngribbin johngribbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Damn Polar is a great tool

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 046d396 into develop Jan 31, 2023
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the enhancement/connection-options branch January 31, 2023 19:16
johngribbin added a commit that referenced this pull request Feb 3, 2023
* 1.3.0-0.1.0: Enhancement - Allow DNS Address (#97)

* Update to latest lnmessage that allows dns

* Allow dns address, storage err handling, lint fix

* Bump ua-parser-js from 1.0.2 to 1.0.33 (#98)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 1.0.2 to 1.0.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@1.0.2...1.0.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Aaron <abarnard@protonmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1.3.0-0.2.0: Enhancement - Connection Options (#99)

* Faster initial data fetching

* Start advanced connection options

* Add http dev mode

* Update to latest lnmessage

* Add full direct connection functionality

* Increment version

* Add connection options to settings page

* Formatting

* Start sidebar

* Tweaks

* Tweals

* Add connection status

* Add refresh button

* Shadow on desktop only

* Handle case where connection status undefined

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Aaron <abarnard@protonmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
johngribbin added a commit that referenced this pull request Feb 4, 2023
)

* Add Koinly & Cointracker csv downloads with hardcoded data

* Add quickbooks and harmony CSVs

* Clean up logic

* Fix fee amount bug and clean up logic

* Fix date formatting

* Remove hardcoded json and hook up commando call for income events

* Update styling

* Rename route and update styles

* Move accounting exports to component with call for income events

* Move copy to i18n file

* Update spacing

* Add sidenav compoent & back button to bkpr route

* Updates

* Remove settings icon from top right

* Remove unused import

* Fix bug caused by z-index & tidy up bkpr loading effect

* Remove redundant div

* Add version update

* Update styling of Menu

* Update Refresh component with loading animation

* Update version

* Fix spacing around menu options

* Feature/bookkeeper account UI tweaks (#102)

* 1.3.0-0.1.0: Enhancement - Allow DNS Address (#97)

* Update to latest lnmessage that allows dns

* Allow dns address, storage err handling, lint fix

* Bump ua-parser-js from 1.0.2 to 1.0.33 (#98)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 1.0.2 to 1.0.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@1.0.2...1.0.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Aaron <abarnard@protonmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1.3.0-0.2.0: Enhancement - Connection Options (#99)

* Faster initial data fetching

* Start advanced connection options

* Add http dev mode

* Update to latest lnmessage

* Add full direct connection functionality

* Increment version

* Add connection options to settings page

* Formatting

* Start sidebar

* Tweaks

* Tweals

* Add connection status

* Add refresh button

* Shadow on desktop only

* Handle case where connection status undefined

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Aaron <abarnard@protonmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Tweak logic to create csv on click

* Make import of date-fns-tz dynamic

* Remove redundant key

* Refactor/csv formatting (#103)

* Refactor data handling

* 1.3.0-0.3.0: Feature - URL Protocol Handlers (#101)

* Add url protocol handlers

* Add register method

* Fix versioning

---------

Co-authored-by: Aaron <abarnard@protonmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Aaron <abarnard@protonmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants