Deprecate multiple_occurrences, removing it on next breaking change #3772
Labels
A-parsing
Area: Parser's logic and needs it changed somehow.
M-breaking-change
Meta: Implementing or merging this will introduce a breaking change.
S-waiting-on-decision
Status: Waiting on a go/no-go before implementing
Milestone
Comments
epage
added
M-breaking-change
epage
added a commit
to epage/clap
that referenced
this issue
May 31, 2022
This changes how occurrences and values are grouped for multiple values. Today, it appears as a bug. If we move forward with clap-rs#3772, then this can make sense.
epage
added a commit
to epage/clap
that referenced
this issue
May 31, 2022
If we felt this was important long-term, we should fix this outside of the Action. Since we might be changing up occurrences (clap-rs#3772), we can probably get away with a hack.
epage
changed the title
2 tasks
epage
added a commit
to epage/clap
that referenced
this issue
Jun 8, 2022
For programs opting into the clap v4 behavior (with `action` or `value_parser` attributes), we'll no longer generate a `multiple_occurrences(true)` call in preparation for deprecating `multiple_occurrences`. See clap-rs#3772.
epage
added a commit
to epage/clap
that referenced
this issue
Jun 8, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #3405, we are adding Actions. This would allow us to fold multiple occurrences into Actions if we are willing for Command::args_override_self to be exclusively the behavior.
This would remove mixing of multiple occurrences and multiple values for positionals, leading us to reject issues like #3763.
This means we need to revisit #2993. We'd need to have different behavior for flags (default to
Extend) and positional arguments (default toSetwith multiple values).The text was updated successfully, but these errors were encountered: