Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deprecated to remove warnings for rustc 1.26 onwards #1242

Merged
merged 2 commits into from
Apr 4, 2018

Conversation

guangie88
Copy link

@guangie88 guangie88 commented Apr 4, 2018

Currently using arg_enum macro on nightly will trigger the following warning:

use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead

This is due to https://github.com/rust-lang/rust/blob/master/src/libstd/ascii.rs#L55. Projects will fail to compile on nightly if #![deny(warnings)] is set.

Resolve by appending #[allow(deprecated)] to affected parts to prevent warnings from bubbling up to the projects using the library.


This change is Reviewable

@mention-bot
Copy link

@guangie88, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp
Copy link
Member

kbknapp commented Apr 4, 2018

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants