Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 2.33 examples links point to 2.33 branch, not master #1973

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

CreepySkeleton
Copy link
Contributor

ATTENTION This PR is against v2-master

This PR fixes links in 2.33 docs so they point to 2.33 examples, not master examples. Cna we have a release with this so it no longer confusers people?

@CreepySkeleton CreepySkeleton requested a review from pksunkara June 11, 2020 11:57
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jun 11, 2020
1973: Make 2.33 examples links point to 2.33 branch, not master r=pksunkara a=CreepySkeleton

<!--
If your PR closes some issues, please write `Closes #XXXX`
where `XXXX` is the number of the issue you want to fix.
Each issue goes on it's own line.
-->
**ATTENTION** This PR is against `v2-master`

This PR fixes links in 2.33 docs so they point to 2.33 examples, not master examples. Cna we have a release with this so it no longer confusers people?

Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Jun 11, 2020

Timed out.

@pksunkara
Copy link
Member

I forgot we don't have bors for v2.

@pksunkara pksunkara merged commit 7127653 into v2-master Jun 11, 2020
@pksunkara pksunkara deleted the 2.33_links branch June 11, 2020 18:12
@CreepySkeleton
Copy link
Contributor Author

@pksunkara Can we please have 2.33.2 released?

@pksunkara
Copy link
Member

@CreepySkeleton go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants