Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lifetimes descriptive #2025

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Make lifetimes descriptive #2025

merged 1 commit into from
Jul 21, 2020

Conversation

CreepySkeleton
Copy link
Contributor

Extracted from #1998

@CreepySkeleton
Copy link
Contributor Author

CreepySkeleton commented Jul 19, 2020 •
edited
Loading

Trailing whitespace is so fucking annoying. We need to do something about that.

Options:

  • Avoid emitting trailing whitespace. I think this would be the best option.
  • Tweak test utilities so they trim trailing whitespace before the comparison.
  • Status quo. Please no.

@pksunkara
Copy link
Member

Avoid emitting trailing whitespace. I think this would be the best option.

I have been meaning to do that. But it was not a priority for 3.0

pksunkara
pksunkara approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 20, 2020
@bors @CreepySkeleton
Merge #2025
60c9811 
2025: Make lifetimes descriptive r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Jul 20, 2020

Build failed:

  • clap-rs.clap

@CreepySkeleton
Copy link
Contributor Author

bors r=pksunkara

bors bot added a commit that referenced this pull request Jul 20, 2020
@bors @CreepySkeleton
Merge #2025
9993e29 
2025: Make lifetimes descriptive r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Jul 20, 2020

Build failed:

  • CI

@pksunkara
Copy link
Member

This needs rebase now.

@CreepySkeleton
Copy link
Contributor Author

bors r=pksunkara

@bors
Copy link
Contributor

bors bot commented Jul 21, 2020

Build succeeded:

@bors bors bot merged commit dd5e6b2 into master Jul 21, 2020
@bors bors bot deleted the descriptive_lifetimes branch July 21, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CreepySkeleton @pksunkara