Possible Value help #3503

ModProg · 2022-02-23T09:15:32Z

unstable-v4 feature
Show help for possible values

#3312

ModProg · 2022-02-23T09:45:11Z

I added the test in a way where both the behaviour with unstable-v4 and without are testet.

tests/builder/help.rs

README.md

Makefile

src/output/help.rs

tests/builder/help.rs

epage · 2022-02-23T14:43:45Z

Thanks for moving this forward!

tests/builder/help.rs

ModProg · 2022-03-01T12:49:39Z

Should we maybe add a rustfmt.toml to the project? That way, contributors with global rustfmt configurations would not need to worry about that before making a commit?

Could be easily generated with rustfmt --print-config default > rustfmt.toml. That way we could also check if it is still default in CI.

epage · 2022-03-01T14:54:17Z

That way, contributors with global rustfmt configurations would not need to worry about that before making a commit?

Maybe its just me but rather than every project having to have a rustfmt.toml, it seems like it'd be better for people not to use a global rustfmt. Maybe there is something I'm missing about the workflow but it seems like formatting should be tied to the repo and not the user.

README.md

src/build/possible_value.rs

src/output/help.rs

ModProg · 2022-03-01T15:10:54Z

Maybe its just me but rather than every project having to have a rustfmt.toml, it seems like it'd be better for people not to use a global rustfmt. Maybe there is something I'm missing about the workflow but it seems like formatting should be tied to the repo and not the user.

Probably depends on how many private projects someone has.

In a refactor for clap-rs#3503, one of the checks for `is_hide_set` got flipped and we are completing hidden `PossibleValue`s rather than visible. Fixes clap-rs#3697

ModProg force-pushed the possible_value_help_in_help branch 2 times, most recently from 105d506 to 336cfb1 Compare February 23, 2022 09:22

ModProg added 2 commits February 23, 2022 10:22

chore: Add unstable-v4 feature

fe83170

feat(help): Show help for possible values

9839cf8

ModProg force-pushed the possible_value_help_in_help branch from 336cfb1 to 9839cf8 Compare February 23, 2022 09:23

ModProg commented Feb 23, 2022

View reviewed changes

tests/builder/help.rs Outdated Show resolved Hide resolved