fix(multicall): Polish user messages #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing all arguments, we've switched from an "unrecognized argument" error to a "unrecognized subcommand" error. While the wording has room for improvement, its at least progress on clap-rs#2862.
For some reason this code path diverged and manually constructed a usage, not following any of our patterns for doing so.
Set expectations for how this can be used and to make sure the right errors are given.
|
cc @fishface60 |
7 tasks
Thanks for picking this up after I ran out of hobby time. The improvements to output look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes a long way towards resolving #2862 and in general polishing multicall for becoming stable.
The only thing that isn't ideal is that the error message refers to it as a subcommand when in some cases its a command.