Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show possible values in generated man file #4082

Merged
merged 4 commits into from
Aug 24, 2022

Commits on Aug 24, 2022

  1. fix: Show possible values in generated man file

    This adds feature parity for mangen with the standard help output. Users
    will now see the list of possible values for value arguments.
    
    One change that was made to make this possible was adding the method
    `get_possible_values` to the public API for an arg. I tried to think of
    a way to get around this, but because this is the interface that the
    help generation uses, and it is part of the crate public interface
    I thing adding it as a part of the public API might be for the best.
    
    fixes: clap-rs#3861
    Calder-Ty committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    6342802 View commit details
    Browse the repository at this point in the history
  2. fix: Take in account possible values being hidden

    This makes sure we take into account the setting that possible args
    is hidden
    Calder-Ty committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ec518e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    069098c View commit details
    Browse the repository at this point in the history
  4. fix: Add possible vals to man for positional args

    Noticed that possible values would not show up for Positional arguments
    as well. Decided to add the changes for those as well.
    Calder-Ty committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a55db43 View commit details
    Browse the repository at this point in the history