Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (fish-completion) Help for value enum #5114

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: (fish-completion) Help for value enum #5114

merged 2 commits into from
Sep 7, 2023

Commits on Sep 7, 2023

  1. test: (completion) enum value help 

    - Breaking for fish shell
- Matching the bad output to make the test pass
    @jporwal05
    jporwal05 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ca06c32 View commit details
    Browse the repository at this point in the history

  2. fix: (fish-completion) Help for value enum 

    Resolves clap-rs#5101

- The completion of value enums now displays accurate help text
- This fix encloses help text in single quotes
- Any text after tab is taken as help text
- Comma in help text is not escaped
- This is because the the help text is now treated as literal
- No variable expansion or command substitution in help text
    @jporwal05
    jporwal05 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    34291a2 View commit details
    Browse the repository at this point in the history